Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Euler 1 dim step option to shortcuts.py #277

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aakashnarayan
Copy link

No description provided.

@inducer
Copy link
Owner

inducer commented Jul 23, 2022

Thanks! Could you look into the linter failure?

Also, this is missing documentation and tests. When writing the documentation, it might be good to remind the user that the stability region for forward Euler includes no nonzero part of the imaginary axis, and therefore forward Euler is unstable for DG operators applied to hyperbolic PDEs discretized with central fluxes.

@inducer
Copy link
Owner

inducer commented Jul 3, 2023

Please add a test and fix the linter. Converting to draft and unsubcribing in the meantime, please request review when ready.

@inducer inducer marked this pull request as draft July 3, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants