Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mirgecom downstream testing to use integrated test runner. #292

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

MTCam
Copy link
Collaborator

@MTCam MTCam commented Nov 14, 2022

Use mirgecom integrated test runner to run lazy, examples, and production testing. Plugs a production testing hole.

NOTE: Currently production testing is disabled due to a snafu with the requirements.txt.

@MTCam MTCam marked this pull request as ready for review November 14, 2022 19:24
@inducer
Copy link
Owner

inducer commented Nov 15, 2022

Thanks for this contribution.

Analogous CI code exists in, at least, arraycontext, pytato, and loopy. What's provided here looks a bit "non-final", and I'd prefer not to have to continue making changes in multiple places as things get finalized. Instead, I'd prefer if mirgecom had a script entrypoint for downstream tests, so that upstream package can defer the policy decision of what should constitute downstream CI can be deferred to mirgecom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants