Vaguely accommodate old floopy behavior of None dimensions in shape

inducer · Nov 7, 2024 · 3ece99a · 3ece99a
1 parent 8f0c97f
commit 3ece99a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/loopy/kernel/array.py b/loopy/kernel/array.py
@@ -645,6 +645,11 @@ def parse_arith(x: ExpressionT | str) -> ArithmeticExpressionT:
         else:
             res = x
 
+        # The Fortran parser may do this, but this is (deliberately) outside
+        # the behavior allowed by types, because the hope is to phase it out.
+        if x is None:
+            return x
+
         assert is_arithmetic_expression(res)
         return res
 

diff --git a/loopy/typing.py b/loopy/typing.py
@@ -40,6 +40,8 @@
 from pymbolic.typing import ArithmeticExpressionT, ExpressionT, IntegerT
 
 
+# The Fortran parser may insert dimensions of 'None', but I'd like to phase
+# that out, so we're not encoding that in the type.
 ShapeType: TypeAlias = Tuple[ArithmeticExpressionT, ...]
 StridesType: TypeAlias = ShapeType