Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ruff and port to mesonpy #99

Merged
merged 9 commits into from
Jul 8, 2024
Merged

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Jul 6, 2024

This does a bit of modernizing as the title says.

The examples are pretty out of date, but the rest of the things seems to be working.

pyproject.toml Show resolved Hide resolved
@alexfikl alexfikl force-pushed the switch-ruff branch 2 times, most recently from a461f3e to a88d793 Compare July 6, 2024 18:42
@alexfikl
Copy link
Contributor Author

alexfikl commented Jul 7, 2024

I've looked around a bit and think I know why the wheel build failures are happening.
https://github.com/inducer/meshpy/actions/runs/9821375911

  1. On Windows, it seems like it's a 32-bit vs 64-bit issue: trying to build a 32 bit extension
    with a 64 bit compiler. Numpy had the same problem BLD: win32 not using python architecture  numpy/numpy#24704.

  2. On Ubuntu, it's an issue with the available numpy wheels. They don't have wheels for pypy38, pypy310 and some i686 combinations in there. That makes the CI try to build numpy from scratch and (besides taking a long time) it eventually fails on PyPy 3.9 manylinux i686.

EDIT: I've added additional skips pp*-manylinux_i686 *-win32. Let me know if you want to support any of those.

@alexfikl alexfikl force-pushed the switch-ruff branch 4 times, most recently from f89a51a to b4e3f4c Compare July 7, 2024 07:30
@alexfikl alexfikl marked this pull request as ready for review July 7, 2024 08:09
pyproject.toml Show resolved Hide resolved
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're trying to make sure that I have to know all the build tools. I appreciate the sentiment. 🤦 😁

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, sorry about that! I was just being lazy and started copying from pyfmmlib :(

I also thought that they used a different editable machinery that allowed pylint to work.. but apparently not :\

@inducer
Copy link
Owner

inducer commented Jul 8, 2024

EDIT: I've added additional skips pp*-manylinux_i686 *-win32. Let me know if you want to support any of those.

Nah. (But thanks for asking.) My logic is mostly, support $\Leftrightarrow$ (mainstream $\lor$ easy).

@inducer
Copy link
Owner

inducer commented Jul 8, 2024

Didn't see anything objectionable, so 🚀 let's do it.

@inducer inducer merged commit 53e8a7a into inducer:main Jul 8, 2024
11 checks passed
@inducer
Copy link
Owner

inducer commented Jul 8, 2024

Thanks!

@alexfikl alexfikl deleted the switch-ruff branch July 8, 2024 16:55
@alexfikl alexfikl mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants