Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vi keys for sidebar #368

Merged
merged 3 commits into from
Jan 8, 2020
Merged

Add vi keys for sidebar #368

merged 3 commits into from
Jan 8, 2020

Conversation

aude
Copy link
Contributor

@aude aude commented Nov 26, 2019

I want to move around in the sidebar identically to how I move around in the source bar.

This change implements vi keys for the sidebar:

  • Add the j/k, g/G, ..., keys supported in the source bar for the sidebar.
  • Unify key handling, to deduplicate code.
  • Add documentation for the vi keys.
  • Add documentation for some undocumented keys.

Note that this pull request is related to #196 and #328.

@inducer
Copy link
Owner

inducer commented Jan 8, 2020

Thanks for your contribution. I've cleaned it up and removed all the duplication. If it passes CI, it's ready to go in.

@inducer inducer merged commit ebfeb34 into inducer:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants