-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global and "by reference" watches #525
base: main
Are you sure you want to change the base?
Conversation
1707058
to
9f20770
Compare
Actually what do you think of making all watches "global"? That's usually how I want watches to behave. |
409e9c7
to
a278c79
Compare
Hmm just as well I'm not entirely happy with the state of this- we don't have access to the right InspectInfo for global watches since it's still being cached at the frame level, so the global watches are presented differently (display type, show detail, etc) in each frame. |
Also, any thoughts on the UI for this stuff? I went with "expression"/"reference" since that made sense to me at the time but "by name"/"by value" might make more sense. And how cumbersome is it to have potentially 4 different kinds of watches? |
d9dca1e
to
23bb7a0
Compare
Haven't read up all the watch-related stuff, but here is a late night thought: This is what comes to mind after seeing the behavior of #150, which saves watch expressions and loads them in every entered frame, which of course fails in many cases. |
Addresses #511
Allows modifying watch expressions in two ways: