Add descend_args to DependencyMapper types #158
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
include_calls: bool | Literal["descend_args"] = True
toDependencyMapper
and a few other small typing fixes.I think this also exposes a typing bug (the mypy CI should fail). I added missing type parameters to
CachedDependencyMapper
and it started complainingfrom https://github.com/inducer/pymbolic/blob/670bbbb188d1b65a64811d401f1c3f71e99f85f6/pymbolic/interop/ast.py#L465=L466. From what I can tell, that can return things that don't have a
.name
attribute, so not sure what the correct types would be. Suggestions?