Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize._get_def_from_ast_container: Use last definition #175

Merged
merged 1 commit into from
Feb 3, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pymbolic/mapper/optimize.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ def _get_def_from_ast_container(
name: str,
node_type: type[AstDefNodeT]
) -> AstDefNodeT:
for entry in container:
# Return the last definition in the container, not the first.
# This is relevant, e.g., in the case of @overload of methods.
for entry in reversed(list(container)):
if isinstance(entry, node_type) and entry.name == name:
return entry

Expand Down
Loading