Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sorting of symbolic tags #476

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Revert sorting of symbolic tags #476

merged 2 commits into from
Nov 28, 2023

Conversation

matthiasdiener
Copy link
Collaborator

@matthiasdiener matthiasdiener commented Nov 28, 2023

Sorting fails when symbolic tags contain bare classes (which can not be compared most of the time).

The attached test case fails without this PR.

This (partially) reverts #462 until we have a better solution (like #467 or #469).

Also, TIL:

class FooTag1:
    pass

class FooTag2:
    pass

>>> FooTag1 < FooTag1
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: '<' not supported between instances of 'type' and 'type'

>>> FooTag1 < FooTag2
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: '<' not supported between instances of 'type' and 'type'

>>> (FooTag1,) < (FooTag1,)
False # 🤔 

>>> (FooTag1,) < (FooTag2,)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: '<' not supported between instances of 'type' and 'type'

Please squash.

Sorting fails when symbolic tags contain bare classes (which can not be
compared most of the time).

The attached test case fails without this PR.
@matthiasdiener matthiasdiener self-assigned this Nov 28, 2023
@matthiasdiener matthiasdiener marked this pull request as ready for review November 28, 2023 19:33
@inducer inducer merged commit 6ccb338 into main Nov 28, 2023
10 checks passed
@inducer inducer deleted the revert-sort-mpi_tags branch November 28, 2023 20:24
nkoskelo pushed a commit to nkoskelo/pytato that referenced this pull request Mar 5, 2024
* Revert sorting of symbolic tags

Sorting fails when symbolic tags contain bare classes (which can not be
compared most of the time).

The attached test case fails without this PR.

* undo doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants