Add duplication checks #550
Draft
+418
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majosm
force-pushed
the
add-duplication-checks
branch
2 times, most recently
from
63c29f3 to
e165c55
Compare
majosm
force-pushed
the
add-duplication-checks
branch
from
e165c55 to
8b0b00c
Compare
majosm
force-pushed
the
add-duplication-checks
branch
3 times, most recently
from
f90083b to
ddb9093
Compare
majosm
force-pushed
the
add-duplication-checks
branch
2 times, most recently
from
64dc616 to
6ac2ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two checks to
CachedMapper-derived mapper class traversals:err_on_collisioninCachedMapper, which checks for multiple distinct instances of input expressions that have the same key. These are duplicates in the incoming DAG.err_on_no_op_duplicationinTransformMapper/TransformMapperWithExtraArgs, which checks for mappings between two distinct expression instances where both the input and the output have the same key. These are duplicates that are produced by the mapper (e.g., the currentCopyMapper.map_*implementations that create new instances even if nothing has changed).Depends on #531 and #549.