Remove the raising to high level operator within Unify Axis #565
+380
−336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed variables we will know the right relationship.
…nd the inames in an IndexLambda.
inducer
reviewed
Nov 25, 2024
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
…ator working on an IndexLambda.
…nternal function.
inducer
reviewed
Jan 13, 2025
…g the equations and propagate that information through.
…can store the reduction string as well.
inducer
reviewed
Jan 16, 2025
pytato/transform/metadata.py
Outdated
| if isinstance(var_ind_name, prim.Variable): | ||
| lhs: str = self.get_var_for_axis(expr.bindings[vname], | ||
| axis_ind) | ||
| if IDX_LAMBDA_INAME.fullmatch(var_ind_name.name): |
There was a problem hiding this comment.
Add an else case here, to document that you've thought about it. E.g.
else:
raise AssertionError()
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
…which cannot be transformed into one.
…dled in IndexLambdas. This propogates metadata through partially indexed axes of arrays.
… version requires us to later check with the index lambda version as well. However, we do not want to convert the expressions to index lambdas permanently.
inducer
reviewed
Feb 5, 2025
pytato/transform/metadata.py
Outdated
Comment on lines
322
to
327
| elif BINDING_NAME_RESERVED_PATTERN.fullmatch(ind_name): | ||
| raise AssertionError(f"Expression: {idx_lambda.expr}" + | ||
| "indexes into an array using a binding name.") | ||
| else: | ||
| raise AssertionError(f"Expression: {idx_lambda.expr}" + | ||
| "indexes into an array with an unknown variable name.") |
There was a problem hiding this comment.
Why are these errors? They can happen (hence AssertionError is misplaced), and I wouldn't consider them illegal. (I've removed them.)
pytato/transform/metadata.py
Outdated
| """ | ||
| return self.combine([base] + [self.rec(subexpr) for | ||
| subexpr in expr.index_tuple]) | ||
| return {} |
There was a problem hiding this comment.
This code path is missing a recursion. (I've added it.)
pytato/transform/metadata.py
Outdated
Comment on lines
563
to
567
| for (ary, ax), ax_var in equations_collector.axis_to_var.items(): | ||
| # Reduction axes do not follow AxisIgnoredForPropagation. | ||
| # They cannot propagate the information to descendant of the array anyway. | ||
| if isinstance(ax, int) and ary.axes[ax].tags_of_type(AxisIgnoredForPropagationTag): # noqa | ||
| ignored_vars.update({ax_var}) |
There was a problem hiding this comment.
Why shouldn't reduction axes participate in this?
pytato/transform/metadata.py
Outdated
| ind_name: str = var_ind_name.name | ||
| matched_pattern = IDX_LAMBDA_RESERVED_INDEX_PATTERN.fullmatch(ind_name) # noqa | ||
| if matched_pattern: | ||
| # matched with an axis index. |
There was a problem hiding this comment.
Did we say this should only apply if the lengths match? (I've added that check.)
inducer
force-pushed
the
remove-raising-revived
branch
from
c47567a to
62f7fb4
Compare
|
Fixes for mypy will come via #581. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.