Reshape simple expressions in index lambda #575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om:nkoskelo/pytato into reshape_simple_expressions_in_index_lambda
|
@inducer this is ready for your review. |
inducer
reviewed
Jan 28, 2025
…hapes that match across the reshape operation. It will also handle shapes with size 1.
…index variables. :)
… both Fortran and C ordering more cleanly.
inducer
reviewed
Jan 30, 2025
There was a problem hiding this comment.
There are piles of seemingly unrelated changes here. What happened?
There was a problem hiding this comment.
Mypy was complaining about keyword arguments that begin with an underscore no longer existing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #574