Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject: hack around to make editable install work #240

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Jul 3, 2024

Same issue as for mypy in inducer/modepy#88.

This adds a few more commits with extra rules and fixes, so probably best looked at commit-by-commit.

pyproject.toml Show resolved Hide resolved
@alexfikl
Copy link
Contributor Author

alexfikl commented Jul 3, 2024

Hm, absolutely no idea why that one test failed on pypy :\

TypeError: expected some sort of stmt, but got '@py_assert3'

Makes it sound like it didn't like some pytest rewriting, but that's not new..

@inducer
Copy link
Owner

inducer commented Jul 3, 2024

🤷 Let's just disable pypy testing then.

pyproject.toml Outdated Show resolved Hide resolved
@alexfikl
Copy link
Contributor Author

alexfikl commented Jul 3, 2024

🤷 Let's just disable pypy testing then.

Any chance this is just on this branch?

@inducer
Copy link
Owner

inducer commented Jul 3, 2024

Any chance this is just on this branch?

Don't care. Life's too short. :)

@alexfikl
Copy link
Contributor Author

alexfikl commented Jul 3, 2024

Don't care. Life's too short. :)

Rerunning seems to have fixed that, so yey! This should be good to go now 😁

@inducer inducer merged commit 444c4b6 into inducer:main Jul 3, 2024
16 checks passed
@alexfikl alexfikl deleted the fix-editable branch July 3, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants