KeyBuilder: change int to direct str representation #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
commented
Sep 3, 2024
Comment on lines
+438
to
+440
| assert keyb(1) == keyb("1") | ||
| assert keyb(1.0) != keyb("1.0") # '1.0' uses hex representation | ||
| assert keyb(1+1j) == keyb("(1+1j)") |
There was a problem hiding this comment.
Not sure if this is an issue. If it is, we could change the KeyBuilder to (int, str(key)).
inducer
reviewed
Sep 3, 2024
| @@ -432,9 +432,13 @@ def test_scalar_hashing() -> None: | |||
| assert keyb(np.int32(1)) == keyb(np.int32(1)) | |||
| assert keyb(np.int32(2)) != keyb(np.int32(1)) | |||
| assert keyb(np.int64(1)) == keyb(np.int64(1)) | |||
| assert keyb(1) == keyb(np.int64(1)) | |||
| assert keyb(1) != keyb(np.int64(1)) | |||
There was a problem hiding this comment.
Wait, I thought the goal was to keep them the same?
There was a problem hiding this comment.
From your answer to my question in #260, my interpretation was that they don't need to be the same. Changing the code like in this PR perhaps also addresses #262.
matthiasdiener
force-pushed
the
keyb-int-str
branch
from
9f739d0
to
2a19397
Compare
matthiasdiener
force-pushed
the
keyb-int-str
branch
from
2a19397
to
7546ab8
Compare
|
Just FYI, the tests pass on PPC64 BE with this patch applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #260.