Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: add strict typing to prefork #270

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

alexfikl
Copy link
Contributor

@alexfikl alexfikl commented Nov 27, 2024

Mostly straightforward, but the socket communication is pretty much ignored for typing.

Don't quite recall, but I think some other package required typing call_capture_output, so went ahead and typed the whole thing.

@alexfikl alexfikl force-pushed the prefork-typing branch 2 times, most recently from 589cd8a to 17ecc73 Compare November 27, 2024 18:49
pytools/prefork.py Outdated Show resolved Hide resolved
@inducer inducer merged commit 29a5017 into inducer:main Nov 27, 2024
17 checks passed
@alexfikl alexfikl deleted the prefork-typing branch November 27, 2024 20:38
@inducer
Copy link
Owner

inducer commented Nov 27, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants