Opt frozen dataclass #272
Merged
Opt frozen dataclass #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
force-pushed
the
opt-frozen-dataclass
branch
from
b883cad
to
ab56985
Compare
alexfikl
reviewed
Nov 28, 2024
| @@ -903,7 +910,7 @@ def new_inner(*args: P.args, **kwargs: P.kwargs) -> R: | |||
| return new_inner | |||
|
|
|||
|
|
|||
| class keyed_memoize_in(Generic[P, R]): # noqa: N801 | |||
There was a problem hiding this comment.
Why is this not needed? I thought it constrained the __call__ inputs
There was a problem hiding this comment.
The problem I encountered is that R does not get bound at construction time, and so mypy helpfully binds it to Never, which it expects as the return value of the function. pyright seemed to agree that R would not get bound.
__call__ is still an R-generic function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.