Skip to content

Conversation

mchev
Copy link

@mchev mchev commented Apr 24, 2024

Since issue #174 has been reopened, here is (once again) a proposal for the refactored system using the <script setup> syntax.

This is a new version of the old PR #175:

  • Removed the dependency on popper.js, which was only used for dropdowns. The new dropdowns no longer require popper.
  • The shared components have been left unchanged (except for the dropdown) and updated for the Composition API. Further enhancements could be made later to improve them.
  • All pages now utilize the <script setup> syntax and Composition API.
  • Using PascalCase for components based on https://vuejs.org/style-guide/rules-strongly-recommended.html recommendations
  • Updated dependencies in order to run the fix-code-style script.

@LouiScura
Copy link

This is great! Should have been included in the last update...

@mst101
Copy link

mst101 commented Jul 8, 2024

It's a good start, but there are issues...

e.g. you have removed the layout: Layout key and moved the <Layout> component inside the vue pages. This means the whole layout will be reloaded whenever you visit a new page.

In Vue 3.3+ you can use the defineOptions macro to ensure the pages remain children of the layout:

defineOptions({
  layout: Layout,
})

See this commit.

Anyway, it appears the team would rather handle this internally, so it will be interesting to see how they choose to do it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants