Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to #829 #845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix to #829 #845

wants to merge 1 commit into from

Conversation

agbcix
Copy link

@agbcix agbcix commented May 17, 2023

[BF] Unconditionally re-initialize sFlow collector counters - fixes #829

Previously the counters were not reset in case the API was unreachable. After writing data to RRDs new counters need to be initialized unconditionally.

In addition to the above, I have:

  • ensured all relevant template output is escaped to avoid XSS attached with <?= $t->ee( $data ) ?> or equivalent.
  • ensured appropriate checks against user privilege / resources accessed
  • API calls (particular for add/edit/delete/toggle) are not implemented with GET and use CSRF tokens to avoid CSRF attacks

Previously the counters were not reset in case the API was unreachable.
After writing data to RRDs new counters need to be initialized.
@barryo barryo requested a review from nickhilliard May 17, 2023 07:55
@barryo barryo added the Pending CLA Contributor license agreement not signed label May 17, 2023
@nickhilliard nickhilliard added Bug and removed Pending CLA Contributor license agreement not signed labels May 23, 2023
@nickhilliard
Copy link
Member

I've had a look at this, but fixing this properly is likely to be more complicated than this patch, e.g. startup considerations, etc. I'll have another look before working out what the best approach is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sflow-to-rrd-handler: spikes when API key disappears
3 participants