-
Notifications
You must be signed in to change notification settings - Fork 0
Workflow
Every change to the code is to be added as a pull request with at least one reviewer(who are not developer or tester). Pull request should be attached to already existing issues. When merging after a review, select the top most option. Pull reviewer is decided when the request is ready for review. Developer is responsible for getting a reviewer for the request.
Each branch that is related to one or several issue(s) should have the following naming conversion: X-issue-name where XXX is the issue number. and the issue-name is the title of the issue. Branch name does not have to be same as issue title, but should be descriptive of the issues.
For example a fictitious issue number 23 with the title "kill ze bugs" has the branch name 23-kill-ze-bugs.
When doing a pull review, the reviewer should make sure all code runs as expected, all tests are green including manual tests and that the branch to be pulled is not behind master. When the pull request is approved the reviewer will merge.
There exist two issue template, one standard and one for bug reports. They only exist for guidance. An issue that is in progress should have: 1 developer and 1 tester. Only issues that have a feature-tag or an epic-tag (or is a demanding bug) should be added to iterations, this is to not give a false perspective of how finished we are with the iteration.
Commits should be descriptive and code changes should be committed with other relevant changes. Formatting and refactoring changes should be kept as their own commits.
Follow IntelliJ formatting standard.