Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 alpha #154

Draft
wants to merge 222 commits into
base: master
Choose a base branch
from
Draft

v1.0.0 alpha #154

wants to merge 222 commits into from

Conversation

conorheins
Copy link
Collaborator

@conorheins conorheins commented Sep 24, 2024

Draft PR to see how hard/easy merging in the v1.0.0 alpha changes would be at this stage

dimarkov and others added 30 commits June 10, 2024 11:47
First past of implementation for named distribution for easy manipulation and inspection of discrete conditional probability distributions.
@conorheins conorheins requested a review from tverbele September 24, 2024 11:00
@Arun-Niranjan
Copy link
Contributor

@conorheins fantastic to see a potential v1 of pymdp!

at 97 files and 21k lines touched, I'd suggest breaking this up into sub PRs that get merged into main. Then you can pull main into this branch and then this PR will slowly get smaller over time.

My general process for this is:

  • sort out the tests to at least get a green build (to maximise signal-to-noise of tests failing)
  • anything that gets deleted because its not used right now (and then break into logical sub units, e.g. deleting a file that isn't used)
  • changes by folder/file, starting with easy ones that are largely self contained.
  • or changes by logical domain (e.g. jax scaffolding)

I'm not sure what verses have as PR guidelines, but I tend to find sub 200 lines (including tests) get the best quality reviews, but if that results in 100 PRs then relaxing this might be better 😅

@Arun-Niranjan
Copy link
Contributor

Also I'm happy to help with reviewing if you upgrade my contributor status to allow me to do so 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.