Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: different focus order in mobile menu side panel #332

Conversation

pspaczek
Copy link
Contributor

@pspaczek pspaczek commented Jan 16, 2024

Before this PR I seated focus before content. In design, the focus should be on the back button. Now everything is adjusted to:
Zrzut ekranu 2024-01-16 o 11 44 03
If back button should be focused after page content open then you need upade component in app directly to this changes -> 6ede363

@pspaczek pspaczek requested review from AlanLes and sonya0504 January 16, 2024 10:52
@pspaczek pspaczek marked this pull request as ready for review January 16, 2024 10:53
@pspaczek pspaczek force-pushed the fix/#329_different_focus_order_in_megamenu_sidepanel branch from 6ede363 to 064dc86 Compare January 16, 2024 11:08
Copy link
Contributor

@AlanLes AlanLes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pspaczek pspaczek merged commit 09f94f3 into infermedica:develop Jan 16, 2024
2 checks passed
@pspaczek pspaczek deleted the fix/#329_different_focus_order_in_megamenu_sidepanel branch January 16, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants