Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error not assignable to type 'StyleValue' in UiTextarea #497

Merged
merged 1 commit into from
May 27, 2024
Merged

fix: error not assignable to type 'StyleValue' in UiTextarea #497

merged 1 commit into from
May 27, 2024

Conversation

pspaczek
Copy link
Contributor

Description

Bump vue-tsc and solve error in UiTextarea

Related Issue

Closes #

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pspaczek pspaczek requested a review from a team as a code owner May 24, 2024 09:45
@pspaczek pspaczek enabled auto-merge (squash) May 24, 2024 09:45
@pspaczek pspaczek force-pushed the fix/error-not-assignable-to-type-StyleValue-in-UiTextarea branch from b7f83ae to 6b1c16b Compare May 24, 2024 09:58
@pspaczek pspaczek requested a review from kubajmarek May 24, 2024 10:31
AlanLes
AlanLes reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@AlanLes AlanLes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one doubt, but overall looks good.

src/components/atoms/UiTextarea/UiTextarea.vue Outdated Show resolved Hide resolved
@pspaczek pspaczek force-pushed the fix/error-not-assignable-to-type-StyleValue-in-UiTextarea branch from 6b1c16b to cd8903b Compare May 24, 2024 11:01
@pspaczek pspaczek requested a review from AlanLes May 24, 2024 11:02
@pspaczek pspaczek force-pushed the fix/error-not-assignable-to-type-StyleValue-in-UiTextarea branch from cd8903b to 0279409 Compare May 27, 2024 08:31
@pspaczek pspaczek force-pushed the fix/error-not-assignable-to-type-StyleValue-in-UiTextarea branch from 0279409 to 1ffb047 Compare May 27, 2024 08:34
pspaczek
pspaczek commented May 27, 2024
View reviewed changes
src/components/atoms/UiTextarea/UiTextarea.vue
width: null,
height: null,
minHeight: null,
width: '',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty strigs works well, then I use it instead undefined

@pspaczek pspaczek merged commit 8251bc3 into develop May 27, 2024
1 check passed
@pspaczek pspaczek deleted the fix/error-not-assignable-to-type-StyleValue-in-UiTextarea branch May 27, 2024 08:48
@pspaczek pspaczek mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanLes AlanLes AlanLes approved these changes

@DanielHajduk98 DanielHajduk98 DanielHajduk98 approved these changes

@kubajmarek kubajmarek Awaiting requested review from kubajmarek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pspaczek @AlanLes @kubajmarek @DanielHajduk98