Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: excess spacing in UiFormField #504

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: excess spacing in UiFormField #504

merged 1 commit into from
Jun 25, 2024

Conversation

pspaczek
Copy link
Contributor

Description

Condition messages section depends on character counter or has error message

Related Issue

Closes #503

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Zrzut ekranu 2024-06-24 o 14 47 05
Zrzut ekranu 2024-06-24 o 14 47 51
Zrzut ekranu 2024-06-24 o 14 48 13

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pspaczek pspaczek requested a review from a team as a code owner June 24, 2024 12:50
AlanLes
AlanLes approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@AlanLes AlanLes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pspaczek pspaczek enabled auto-merge (squash) June 24, 2024 19:45
@pspaczek pspaczek merged commit 106626d into develop Jun 25, 2024
1 check passed
@pspaczek pspaczek deleted the fix/503 branch June 25, 2024 05:52
@pspaczek pspaczek mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanLes AlanLes AlanLes approved these changes

@sonya0504 sonya0504 sonya0504 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] Excess spacing in UiFormField component
3 participants
@pspaczek @AlanLes @sonya0504