feat: in UiQuestion add an optional icon for the Why button #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspaczek
reviewed
Sep 12, 2024
| @@ -295,6 +307,7 @@ const defaultProps = computed(() => { | |||
| icon, | |||
| ...props.iconInfoAttrs, | |||
| }, | |||
| iconWhyAttrs: { ...props.iconWhyAttrs }, | |||
There was a problem hiding this comment.
icon:info it shouldn't be added by default?
There was a problem hiding this comment.
I think an icon shouldn't be default because it should be visible only for sex question. The rest of the questions have a rationale button without an icon:
pspaczek
reviewed
Sep 12, 2024
| @@ -295,6 +307,7 @@ const defaultProps = computed(() => { | |||
| icon, | |||
| ...props.iconInfoAttrs, | |||
| }, | |||
| iconWhyAttrs: { ...props.iconWhyAttrs }, | |||
There was a problem hiding this comment.
Suggested change
| iconWhyAttrs: { ...props.iconWhyAttrs }, | |
| iconWhyAttrs: { | |
| icon: 'info, | |
| ...props.iconWhyAttrs | |
| }, |
pspaczek
reviewed
Sep 12, 2024
| @@ -108,6 +110,11 @@ | |||
| v-bind="buttonWhyAttrs" | |||
| class="ui-button--small ui-button--text" | |||
| > | |||
| <UiIcon | |||
| v-if="iconWhyAttrs.icon" | |||
There was a problem hiding this comment.
Suggested change
| v-if="iconWhyAttrs.icon" | |
| v-if="defaultProps.iconWhyAttrs.icon" |
pspaczek
reviewed
Sep 12, 2024
There was a problem hiding this comment.
icon info should be a default view for why and we don't need a new stories
pspaczek
approved these changes
Sep 12, 2024
kubajmarek
approved these changes
Sep 12, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It adds an optional
iconto the why button inUiQuestion. I need this icon because question about sex has this icon:Related Issue
Closes #
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: