Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update css variables (MGPFE-2127) #533

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

sonya0504
Copy link
Contributor

Description

Using figma-to-css.mjs update css variables to the newest.
I added two variables to the local file .env: FIGMA_TOKEN and FIGMA_FILE_ID to make it easier to use
Update UiHeading, UiCheckbox and UiIcon with new css variables.

Related Issue

MGPFE-2127
Closes #

Motivation and Context

CL should be in line with Figma

How Has This Been Tested?

Storybook

Screenshots (if appropriate):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@sonya0504 sonya0504 self-assigned this Jan 2, 2025
@sonya0504 sonya0504 requested a review from a team as a code owner January 2, 2025 13:21
Copy link
Contributor

@DanielHajduk98 DanielHajduk98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, moving the figma file id to env was long-overdue.

@sonya0504 sonya0504 merged commit 2f9d4bc into develop Jan 3, 2025
1 check passed
@sonya0504 sonya0504 deleted the feat/MGPFE-2127 branch January 3, 2025 06:36
@kubajmarek kubajmarek mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants