Fi 3499 cancer resources #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpassas
force-pushed
the
fi-3499-cancer-resources
branch
2 times, most recently
from
963bf9d to
65f9cf4
Compare
patient id specific to cancer id updates rename bundle
rpassas
force-pushed
the
fi-3499-cancer-resources
branch
from
65f9cf4 to
5dfb3c3
Compare
360dgries
approved these changes
Dec 6, 2024
dehall
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Unfortunately this new file seems to be breaking something and I'm not quite sure what yet. Hitting the /Patient endpoint returns 7 patients which seems right, but the patient picker only displays 1 or 2.
Latest on main:
This branch:
The first time I tried it was before the rebase and file rename, and both the new record and the carin patient showed up, now it's just the new record. Files are loaded in alphabetical order so I think this puts something in a bad state and the subsequent files don't load correctly.
I'm not sure yet but my guess is that it's related to re-using ids from the other files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding cancer-specific resources for exchanging mCode conformant data.
Code changes
Including a new transaction bundle with mCode resources.