Fix killing leader causing follower/learner core dump

Signed-off-by: Jin Hai <[email protected]>
infiniflow · Dec 24, 2024 · 50ede97 · 50ede97
1 parent 4973930
commit 50ede97
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/network/peer_thrift_client.cpp b/src/network/peer_thrift_client.cpp
@@ -337,6 +337,11 @@ void PeerClient::HeartBeat(HeartBeatPeerTask *peer_task) {
                 peer_task->error_code_ = static_cast<i64>(ErrorCode::kCantConnectLeader);
                 return;
             }
+            case TTransportExceptionType::NOT_OPEN: {
+                peer_task->error_message_ = thrift_exception.what();
+                peer_task->error_code_ = static_cast<i64>(ErrorCode::kCantConnectLeader);
+                return;
+            }
             default: {
                 String error_message = "Heartbeat: error happens when data transfer to leader";
                 UnrecoverableError(error_message);

diff --git a/src/storage/io/s3_client_minio.cpp b/src/storage/io/s3_client_minio.cpp
@@ -126,7 +126,7 @@ Status S3ClientMinio::BucketExists(const String &bucket_name) {
                 return Status::MinioInvalidAccessKey(resp.Error().String());
             }
             default: {
-                UnrecoverableError(fmt::format("Unable to do bucket existence check: {}", resp.Error().String()));
+                UnrecoverableError(fmt::format("Unable to do bucket existence check: {}, Please check if the MINIO connection", resp.Error().String()));
                 return Status::OK();
             }
         }