Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Add highlight columns #1994

Merged
merged 18 commits into from
Oct 13, 2024
Merged

API: Add highlight columns #1994

merged 18 commits into from
Oct 13, 2024

Conversation

JinHai-CN
Copy link
Contributor

@JinHai-CN JinHai-CN commented Oct 8, 2024

What problem does this PR solve?

SQL:
SELECT col1, col2 HIGHLIGH col1 FROM tbl1 SEARCH MATCH TEXT ('col1', 'off', 'topn=4');

Python API:
table_object.output(["*"]).highlight('body').match_text('body', question, 2).to_df()

HTTP API:

{
     "output":
     [
         "*"
     ],
     "highlight":
     [
         "col1"
     ]
}

Issue link:#1861

Type of change

  • New Feature (non-breaking change which adds functionality)

@JinHai-CN JinHai-CN added the wip work in progress label Oct 8, 2024
@yuzhichang yuzhichang added ci PR can be test and removed wip work in progress labels Oct 10, 2024
@yuzhichang yuzhichang force-pushed the fix311 branch 4 times, most recently from 4e5a0b5 to 48311ba Compare October 11, 2024 09:27
@yuzhichang yuzhichang added wip work in progress and removed ci PR can be test labels Oct 11, 2024
@yuzhichang yuzhichang added ci PR can be test and removed wip work in progress labels Oct 12, 2024
yuzhichang and others added 4 commits October 12, 2024 11:50
Bind highlight info into PhysicalProject
Regenerate parser
Added highlight.slt
Signed-off-by: Jin Hai <[email protected]>
@JinHai-CN JinHai-CN merged commit b906631 into infiniflow:main Oct 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci PR can be test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants