Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BM25 score for PhraseDocIterator #2404

Merged
merged 2 commits into from
Dec 24, 2024

Conversation

yangzq50
Copy link
Contributor

@yangzq50 yangzq50 commented Dec 24, 2024

What problem does this PR solve?

Update IDF formula for PhraseDocIterator
reference: https://lucene.apache.org/core/10_1_0/core/org/apache/lucene/search/similarities/BM25Similarity.html#idfExplain(org.apache.lucene.search.CollectionStatistics,org.apache.lucene.search.TermStatistics[])

Issue link:#1320

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • Refactoring
  • Test cases

@yangzq50 yangzq50 requested a review from yuzhichang December 24, 2024 07:58
@yangzq50 yangzq50 added the ci PR can be test label Dec 24, 2024
@JinHai-CN JinHai-CN merged commit 4973930 into infiniflow:main Dec 24, 2024
7 checks passed
@yangzq50 yangzq50 deleted the fix_phrase_bm25 branch December 24, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci PR can be test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants