Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the usage of dict #2681

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Conversation

yqkcn
Copy link
Contributor

@yqkcn yqkcn commented Sep 30, 2024

What problem does this PR solve?

Simplify the usage of dictionaries

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

@KevinHuSh
Copy link
Collaborator

Really impressive!

This alteration changes the out comes though.

@yqkcn
Copy link
Contributor Author

yqkcn commented Sep 30, 2024

got it...

@yqkcn
Copy link
Contributor Author

yqkcn commented Sep 30, 2024

Really impressive!

This alteration changes the out comes though.

Please review again, I feel like I didn't misunderstand this time

@KevinHuSh KevinHuSh merged commit ae5a877 into infiniflow:main Sep 30, 2024
1 check passed
Halfknow pushed a commit to Halfknow/ragflow that referenced this pull request Nov 11, 2024
### What problem does this PR solve?
Simplify the usage of dictionaries

### Type of change

- [x] Refactoring

---------

Co-authored-by: Kevin Hu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants