Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add Copy request to alerting chart #121

Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore: add Copy request to alerting chart #121

merged 2 commits into from
Feb 13, 2025

Conversation

yaojp123
Copy link
Contributor

@yaojp123 yaojp123 commented Feb 13, 2025

What does this PR do

This pull request includes several updates to the release notes and various improvements to the DataManagement and System components. The most significant changes involve adding new features to the alerting chart, enhancing the widget functionality, and updating the cluster form handling.

Release Notes Updates:

  • Updated release notes to include new features: "Copy request to alerting chart" and "credential settings for agent in enrolling agent." [1] [2]

Widget Enhancements:

  • Added onResultChange prop to Chart.jsx to handle result changes and trigger updates. [1] [2] [3] [4] [5] [6]
  • Included a copy-to-clipboard feature in WidgetLoader.jsx for copying request data. [1] [2] [3]
  • Updated WidgetLoader.less to style the new copy feature.

Cluster Form Updates:

  • Modified ClusterForm.js to handle agent credentials more effectively, ensuring agent_basic_auth is always set. [1] [2]
  • Improved error handling in cluster.js by using optional chaining for the error property.

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@silenceqi silenceqi merged commit 4e82154 into main Feb 13, 2025
6 checks passed
@silenceqi silenceqi deleted the chore-chart branch February 13, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants