Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include bucket conditions information in rule detail API response #125

Merged
merged 1 commit into from
Feb 13, 2025
Merged

feat: include bucket conditions information in rule detail API response #125

merged 1 commit into from
Feb 13, 2025

Conversation

silenceqi
Copy link
Contributor

@silenceqi silenceqi commented Feb 13, 2025 •
edited
Loading

What does this PR do

include bucket conditions information in rule detail API response

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

luohoufu
luohoufu approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luohoufu luohoufu merged commit b8138de into main Feb 13, 2025
6 checks passed
@luohoufu luohoufu deleted the rule-detail branch February 13, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luohoufu luohoufu luohoufu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silenceqi @luohoufu