chore: remove unused code with MetricBase
#132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request includes significant changes to the
insight
module, primarily focusing on the removal of theMetricBase
type and associated API endpoints. The changes also involve cleaning up imports and schema registrations related to the removed type.Removal of
MetricBase
type and associated API endpoints:model/insight/metric_data.go
: Removed theMetricBase
type definition and its associated fields.plugin/api/insight/api.go
: Removed API endpoints for creating, updating, and deleting metrics.plugin/api/insight/metric.go
: Deleted the entire file, which contained the implementation of the metric-related API endpoints.Cleanup of imports and schema registrations:
main.go
: Removed the schema registration forMetricBase
.model/insight/metric_data.go
: Removed the import oform
since it is no longer needed.plugin/api/platform/domain.go
: Removed imports and collection metadata related toMetricBase
. [1] [2]Rationale for this change
Standards checklist