Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust TopN #96

Merged
merged 15 commits into from
Jan 23, 2025
Merged

chore: adjust TopN #96

merged 15 commits into from
Jan 23, 2025

Conversation

yaojp123
Copy link
Contributor

@yaojp123 yaojp123 commented Jan 23, 2025 •
edited by luohoufu
Loading

What does this PR do

  1. add metric config to view's fields
  2. add complex fields to view
  3. adjust TopN

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

yaojiping added 14 commits January 16, 2025 16:58
chore: optimize the chart when only the color metric is selected in TopN
fdb2603
chore: add metric_config to form of View's field
ce40cfd
feat: add Complex Field to View
53d4e61
chore: adjust topn's metrics
01ac0e2
fix: fix the issue of switching metrics in TopN
c7a6b4a
chore: add columns(function, format) to Complex fields
2d031be
chore: verify if the complex field is builtin
a06e97b
fix: set func to max by default in create complex field
298c23c
chore: change text of button for fetching data to Apply in TopN
d901947
chore: check if metric support some statistics if rollup is enabled
fdad960
fix: add time_field to params of fetching data if statistic is la…
379936b 
…tency``
chore: check if field support some statistics if rollup is enabled
e611546
chore: remove layout in view
b761823
fix: format does not work in TopN
3523da0
@yaojp123 yaojp123 changed the title chore: adjust TopN WIP: chore: adjust TopN Jan 23, 2025
@luohoufu luohoufu self-requested a review January 23, 2025 11:50
@yaojp123 yaojp123 changed the title WIP: chore: adjust TopN chore: adjust TopN Jan 23, 2025
luohoufu
luohoufu approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luohoufu luohoufu merged commit d828fe8 into main Jan 23, 2025
5 of 6 checks passed
@luohoufu luohoufu deleted the chore-topn branch January 23, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luohoufu luohoufu luohoufu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaojp123 @luohoufu