Publish image for infinispan-test, replaces Jenkins stage 'Image'

[rigazilla]

Workflow to build and publish infinispan server image on quay.io/infinispan-test

[ryanemerson]

Thanks @rigazilla, overall LGTM just a few minor things. Do you have a link to the corresponding Infinispan action? If I can see the user of this, it will give me the full context to review more thoroughly.

[ryanemerson]

Very minor nitpick, I would rename the action to just publish_image.yml as we have both call and dispatch targets.

[rigazilla]

Thanks @rigazilla, overall LGTM just a few minor things. Do you have a link to the corresponding Infinispan action? If I can see the user of this, it will give me the full context to review more thoroughly.

It will be based on this: https://github.com/rigazilla/infinispan/blob/main/.github/workflows/on_run_publish_image.yml
it needs some updates first

[rigazilla]

Very minor nitpick, I would rename the action to just publish_image.yml as we have both call and dispatch targets.

yeah ok, the naming convention I'm trying to apply doesn't work very well... too verbose

[ryanemerson]

It will be based on this: https://github.com/rigazilla/infinispan/blob/main/.github/workflows/on_run_publish_image.yml
it needs some updates first

Thanks, that's really helpful.

So looking at you current code, it seems like for PRs we need to wait for all tests to run before the image is built. This makes sense for pushes to branches, but would it be possible to make it so that the workflow is triggered on PR open? Ideally I wouldn't have to wait ~1h before the image build happens.

[rigazilla]

It will be based on this: https://github.com/rigazilla/infinispan/blob/main/.github/workflows/on_run_publish_image.yml
it needs some updates first

Thanks, that's really helpful.

So looking at you current code, it seems like for PRs we need to wait for all tests to run before the image is built. This makes sense for pushes to branches, but would it be possible to make it so that the workflow is triggered on PR open? Ideally I wouldn't have to wait ~1h before the image build happens.

oh that was my intent, but is gone lost when I moved out the publishing code from the main workflow. I'll work on that

if this PR looks good, is it ok for a merge?
this way I can point the main branch instead of this in the other workflows and simplify things

[ryanemerson]

I don't mind whether we use camelCase or kebab-case, but let's try to be consistent with the input element across our various workflows.

[rigazilla]

let's go with camel

[ryanemerson]

if this PR looks good, is it ok for a merge?

Do you have a link to a successful run from your fork?

[rigazilla]

if this PR looks good, is it ok for a merge?

Do you have a link to a successful run from your fork?

yep, I'm running on my fork for now:

• publish for PR
• publish for PUSH

published images

[ryanemerson]

Thanks @rigazilla