Tolerations and TopologySpreadConstraints. Fixes #1803 and #1844 #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanemerson
reviewed
Jun 5, 2024
| // From Infinispan CR to pods | ||
| areEqual := false | ||
| for _, v := range pod.Spec.Tolerations { | ||
| if reflect.DeepEqual(v, ispn.Spec.Scheduling.Tolerations[0]) { |
There was a problem hiding this comment.
We can just do assert.EqualValues() here on each of the tolerations.
There was a problem hiding this comment.
k8s adds some tolerations, so arrays are not equal. so we need to check if our toleration is in the array
test/e2e/infinispan/smoke_test.go
Outdated
| } | ||
| } | ||
| assert.True(areEqual) | ||
| assert.True(reflect.DeepEqual(pod.Spec.TopologySpreadConstraints, ispn.Spec.Scheduling.TopologySpreadConstraints)) |
test/e2e/infinispan/smoke_test.go
Outdated
| @@ -89,6 +103,22 @@ func verifyDefaultAuthention(require *require.Assertions, ispn *v1.Infinispan) { | |||
| testAuthentication(ispn, schema, user, pass) | |||
| } | |||
|
|
|||
| // Make sure no PVCs were created | |||
There was a problem hiding this comment.
I don't think this comment is valid.
rigazilla
force-pushed
the
top-tol-1803-1844
branch
from
09dbcaf
to
f1206e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds spec.scheduling.tolerations spec.scheduling.topologySpreadConstraints.
see #1803 #1844