IPROTO-155 Reduce FileDescriptor memory usage #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use ArrayList instead of LinkedList * Resolve annotations eagerly
pruivo
reviewed
Feb 9, 2024
|
|
||
| private void calculateSize(Map<String, FileDescriptor> descriptors) { | ||
| for (Map.Entry<String, FileDescriptor> descriptor : descriptors.entrySet()) { | ||
| System.out.println("Total Size = " + GraphLayout.parseInstance(descriptor.getValue()).totalSize()); |
fax4ever
approved these changes
Feb 9, 2024
| * @return the map of annotations | ||
| * @throws AnnotationParserException if parsing of annotations fails | ||
| */ | ||
| Map<String, AnnotationElement.Annotation> getAnnotations() throws AnnotationParserException; |
There was a problem hiding this comment.
Maybe we can keep the method implemented as as default simpy delegating to getProcessedAnnotation("")
|
Sorry @tristantarrant I only noticed running this patch on current Infinispan main, that there are some cases where the annotations field is filled and An idea to keep the optimization, is to fill the annotations list only if:
at the end of processAnnotations methods. WTDY? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/IPROTO-155
Parse annotations eagerly to avoid keeping them around.