Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional typescript options to cli output #623

Conversation

JessWallin
Copy link
Contributor

Addresses #611

I'm not totally sure this is what you had in mind for this issue, but please let me know! I'm happy to keep working on this until it's the right solution.

@jamonholmgren jamonholmgren merged commit 6ca91b6 into infinitered:master Oct 8, 2019
@jamonholmgren
Copy link
Member

Looks great Jess! Thanks so much!

@jamonholmgren
Copy link
Member

I was a little quick on the trigger, @JessWallin -- we need to make sure the new file gets copied over if it's a TypeScript project.

You can do that by adding it here (in a new PR):

if (props.language === 'typescript') {
files.push('src/types.js.ejs')
files.push('tsconfig.json.ejs')
files.push('tslint.json.ejs') // TODO: swap out TSlint for ESlint in generated CLIs
}

@JessWallin
Copy link
Contributor Author

Submitting those changes now, @jamonholmgren

@jamonholmgren
Copy link
Member

Ref #631 but my fault, not necessary.

@infinitered-circleci
Copy link

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants