fix(cli): add --legacy-peer-deps for npm users (#2823 by @frankcalise)

infinitered · Oct 29, 2024 · e59d880 · e59d880
1 parent f82f324
commit e59d880
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/commands/new.ts b/src/commands/new.ts
@@ -748,9 +748,11 @@ module.exports = {
         startSpinner(unboxingMessage)
 
         // do base install
-        await packager.install({ ...packagerOptions, onProgress: log })
+        const installCmd = packager.installCmd({ packagerName })
+        await system.run(installCmd, { onProgress: log })
         // now that expo is installed, we can run their install --fix for best Expo SDK compatibility
-        await system.run("npx expo install --fix", { onProgress: log })
+        const forwardOptions = packagerName === "npm" ? " -- --legacy-peer-deps" : ""
+        await system.run(`npx expo install --fix${forwardOptions}`, { onProgress: log })
 
         stopSpinner(unboxingMessage, "🧶")
       }

diff --git a/src/tools/packager.ts b/src/tools/packager.ts
@@ -146,7 +146,7 @@ function installCmd(options: PackageRunOptions) {
   } else if (options.packagerName === "yarn") {
     return `yarn install${silent}`
   } else if (options.packagerName === "npm") {
-    return `npm install${silent}`
+    return `npm install${silent} --legacy-peer-deps`
   } else if (options.packagerName === "bun") {
     return `bun install${silent}`
   } else {