Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: exported component access should be restricted with appropriate permissions #73

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix: exported component access should be restricted with appropriate permissions #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ff9c9
Update manifest with permission to use sentinel
KCeh Jul 14, 2024
7f79a81
Reneme timber tool constants object
KCeh Jul 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions sentinel/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,20 @@

<uses-permission android:name="android.permission.POST_NOTIFICATIONS" />

<permission
android:name="com.infinum.sentinel.permission.ACCESS_SENTINEL"
android:protectionLevel="signature" />

<application>

<activity
android:name=".ui.main.SentinelActivity"
android:exported="true"
android:label="@string/sentinel_name"
android:taskAffinity="com.infinum.sentinel"
android:theme="@style/Sentinel.Theme">
<meta-data
android:theme="@style/Sentinel.Theme"
android:permission="com.infinum.sentinel.permission.ACCESS_SENTINEL">
<meta-data
android:name="@string/sentinel_infinum_monitored"
android:value="false" />
</activity>
Expand Down
2 changes: 1 addition & 1 deletion tool-timber/src/main/kotlin/com/infinum/sentinel/SentinelFileTree.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import android.content.Context
import com.infinum.sentinel.ui.logger.models.BaseEntry
import com.infinum.sentinel.ui.logger.models.FlowBuffer
import com.infinum.sentinel.ui.logger.models.Level
import com.infinum.sentinel.ui.shared.Constants.LOG_DATE_TIME_FORMAT
import com.infinum.sentinel.ui.shared.TimberToolConstants.LOG_DATE_TIME_FORMAT
import com.infinum.sentinel.ui.shared.LogFileResolver
import java.io.File
import java.text.SimpleDateFormat
Expand Down
2 changes: 1 addition & 1 deletion tool-timber/src/main/kotlin/com/infinum/sentinel/ui/logger/LoggerAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import android.view.ViewGroup
import androidx.recyclerview.widget.ListAdapter
import com.infinum.sentinel.SentinelFileTree
import com.infinum.sentinel.databinding.SentinelItemLogBinding
import com.infinum.sentinel.ui.shared.Constants.LOG_DATE_TIME_FORMAT
import com.infinum.sentinel.ui.shared.TimberToolConstants.LOG_DATE_TIME_FORMAT
import java.text.SimpleDateFormat
import java.util.Locale

Expand Down
2 changes: 1 addition & 1 deletion tool-timber/src/main/kotlin/com/infinum/sentinel/ui/logs/LogsAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import android.view.LayoutInflater
import android.view.ViewGroup
import androidx.recyclerview.widget.ListAdapter
import com.infinum.sentinel.databinding.SentinelItemLogFileBinding
import com.infinum.sentinel.ui.shared.Constants.LOG_DATE_TIME_FORMAT
import com.infinum.sentinel.ui.shared.TimberToolConstants.LOG_DATE_TIME_FORMAT
import java.io.File
import java.text.SimpleDateFormat
import java.util.Locale
Expand Down
2 changes: 1 addition & 1 deletion ...m/infinum/sentinel/ui/shared/Constants.kt → ...sentinel/ui/shared/TimberToolConstants.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
package com.infinum.sentinel.ui.shared

internal object Constants {
internal object TimberToolConstants {
const val LOG_DATE_TIME_FORMAT = "yyyy-MM-dd'T'HH:mm:ss.SSSZ"
}
Loading