Init #1
Merged
Init #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goranalkovic-infinum
previously approved these changes
Jan 19, 2024
goranalkovic-infinum
approved these changes
Jan 19, 2024
piqusy
reviewed
Jan 19, 2024
| @@ -0,0 +1,3 @@ | |||
| # Project Specific | |||
| /vendor | |||
| /.vscode | |||
There was a problem hiding this comment.
Suggested change
| /.vscode | |
| /.vscode | |
| # Mac OS custom attribute store and thumbnails | |
| *.DS_Store | |
| ._* |
|
|
||
| # Eightshift Forms Utils Library | ||
|
|
||
| Eightshift Forms Utils library is a set of helpers and utils that can be used in the main Eightshift Forms plugin or additional Add-on plugins. |
There was a problem hiding this comment.
Suggested change
| Eightshift Forms Utils library is a set of helpers and utils that can be used in the main Eightshift Forms plugin or additional Add-on plugins. | |
| Eightshift Forms Utils library is a set of helpers and utils that can be used in the main Eightshift Forms plugin or additional Add-ons. |
| use EightshiftLibs\Blocks\AbstractBlocks; | ||
|
|
||
| /** | ||
| * Class AbstractUtilsBaseRoute |
There was a problem hiding this comment.
Suggested change
| * Class AbstractUtilsBaseRoute | |
| * Class UtilsBlocks |
| <?php | ||
|
|
||
| /** | ||
| * Class Blocks is the base class for Gutenberg blocks registration. |
There was a problem hiding this comment.
Suggested change
| * Class Blocks is the base class for Gutenberg blocks registration. | |
| * Class UtilsBlocks is the base class for Gutenberg blocks registration. |
Comment on lines
+445
to
+448
| public const API_RESPONSE_CODE_ERROR = 400; | ||
| public const API_RESPONSE_CODE_ERROR_MISSING = 404; | ||
| public const API_RESPONSE_CODE_ERROR_SERVER = 500; | ||
| public const API_RESPONSE_CODE_ERROR_FORBIDDEN = 403; |
There was a problem hiding this comment.
Suggested change
| public const API_RESPONSE_CODE_ERROR = 400; | |
| public const API_RESPONSE_CODE_ERROR_MISSING = 404; | |
| public const API_RESPONSE_CODE_ERROR_SERVER = 500; | |
| public const API_RESPONSE_CODE_ERROR_FORBIDDEN = 403; | |
| public const API_RESPONSE_CODE_ERROR = 400; | |
| public const API_RESPONSE_CODE_ERROR_FORBIDDEN = 403; | |
| public const API_RESPONSE_CODE_ERROR_MISSING = 404; | |
| public const API_RESPONSE_CODE_ERROR_SERVER = 500; |
| } | ||
|
|
||
| /** | ||
| * Return counries filtered by some key for multiple usages. |
There was a problem hiding this comment.
Suggested change
| * Return counries filtered by some key for multiple usages. | |
| * Return countries filtered by some key for multiple usages. |
| } | ||
|
|
||
| /** | ||
| * Output select options ass array from html string. |
There was a problem hiding this comment.
Suggested change
| * Output select options ass array from html string. | |
| * Output select options as array from HTML string. |
Comment on lines
+841
to
+843
| * Clean url from query params. | ||
| * | ||
| * @param string $url Url to clean. |
There was a problem hiding this comment.
Suggested change
| * Clean url from query params. | |
| * | |
| * @param string $url Url to clean. | |
| * Clean URL from query params. | |
| * | |
| * @param string $url URL to clean. |
| 'layoutContent' => [ | ||
| [ | ||
| 'component' => 'intro', | ||
| 'introTitle' => \__('Disclamer', 'eightshift-forms'), |
There was a problem hiding this comment.
Suggested change
| 'introTitle' => \__('Disclamer', 'eightshift-forms'), | |
| 'introTitle' => \__('Disclaimer', 'eightshift-forms'), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description