Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.0.0 #11

Merged
merged 24 commits into from
Jul 23, 2024
Merged

Release 3.0.0 #11

merged 24 commits into from
Jul 23, 2024

Conversation

iruzevic
Copy link
Member

@iruzevic iruzevic commented Jul 20, 2024 •
edited
Loading

Removed

  • FD_EMAIL_RESPONSE_TAGS, FD_ADDON, FD_SUCCESS_REDIRECT, FD_ENTRY_ID constants.
  • getApiPublicAdditionalDataOutput method.
  • resultOutputItems, resultOutputParts responseOutputKeys enums.
  • downloads successRedirectUrlKeys enum.

Added

  • FD_PARAMS_ORIGINAL_DEBUG, FD_SECURE_DATA constants.
  • getStateSuccessRedirectUrlKeys and getStateSuccessRedirectUrlKey methods.
  • Additional level of security check for the form data.
  • secureData params enum.
  • formSecureData attr enum.
  • processExternally, processExternally, trackingEventName, trackingAdditionalData, hideGlobalMsgOnSuccess, hideFormOnSuccess, variation, entry and formId responseOutputKeys enums.
  • entry, customResultOutput successRedirectUrlKeys enums.

@iruzevic iruzevic requested review from dingo-d and a team July 20, 2024 11:11
@iruzevic iruzevic self-assigned this Jul 20, 2024
piqusy
piqusy previously approved these changes Jul 20, 2024
View reviewed changes
Copy link

@piqusy piqusy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏🏼

Just one suggestions

src/Rest/Routes/AbstractUtilsBaseRoute.php Outdated Show resolved Hide resolved
dingo-d
dingo-d requested changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@dingo-d dingo-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor grammar things I've noticed, nothing major 👍🏼

src/Config/UtilsConfig.php Outdated Show resolved Hide resolved
src/Rest/Routes/AbstractUtilsBaseRoute.php Outdated Show resolved Hide resolved
src/Rest/Routes/AbstractUtilsBaseRoute.php Outdated Show resolved Hide resolved
src/Rest/Routes/AbstractUtilsBaseRoute.php Outdated Show resolved Hide resolved
dadadavorin
dadadavorin previously approved these changes Jul 22, 2024
View reviewed changes
Copy link

@dadadavorin dadadavorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@iruzevic iruzevic dismissed stale reviews from dadadavorin and piqusy via 545891f July 22, 2024 09:42
iruzevic and others added 2 commits July 22, 2024 11:43
@iruzevic @dingo-d @piqusy
Apply suggestions from code review
c2a83c4 
Co-authored-by: Denis Žoljom <[email protected]>
Co-authored-by: Ivan Ramljak <[email protected]>
@iruzevic
adding changelog
098c817
@iruzevic iruzevic requested a review from dingo-d July 22, 2024 09:44
@iruzevic iruzevic merged commit 91620df into main Jul 23, 2024
4 checks passed
@iruzevic iruzevic deleted the feature/gated branch July 23, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dadadavorin dadadavorin dadadavorin approved these changes

@piqusy piqusy piqusy approved these changes

@dingo-d dingo-d dingo-d approved these changes

Assignees

@iruzevic iruzevic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iruzevic @dingo-d @piqusy @dadadavorin