Merge pull request #41 from infinum/fix/misc

Misc minor fixes
infinum · Sep 6, 2024 · 2b3b1c1 · 2b3b1c1
2 parents c2b4d83 + f8fb412
commit 2b3b1c1
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/blocks/init/src/Blocks/components/video/manifest.json b/blocks/init/src/Blocks/components/video/manifest.json
@@ -51,7 +51,7 @@
 			"default": "metadata"
 		},
 		"videoPosterId": {
-			"type": "string"
+			"type": "number"
 		},
 		"videoPosterUrl": {
 			"type": "string"

diff --git a/blocks/init/src/Blocks/components/video/video.php b/blocks/init/src/Blocks/components/video/video.php
@@ -26,7 +26,6 @@
 }
 
 $videoMimeType = Helpers::checkAttr('videoMimeType', $attributes, $manifest);
-$videoPosterId = Helpers::checkAttr('videoPosterId', $attributes, $manifest);
 $videoPosterUrl = Helpers::checkAttr('videoPosterUrl', $attributes, $manifest);
 $videoLoop = Helpers::checkAttr('videoLoop', $attributes, $manifest);
 $videoAutoplay = Helpers::checkAttr('videoAutoplay', $attributes, $manifest);
@@ -47,7 +46,6 @@
 	class="<?php echo esc_attr(Helpers::getTwPart('video', $manifest)); ?>"
 	<?php echo esc_attr($additionalAttributes); ?>
 	preload="<?php echo esc_attr($videoPreload); ?>"
-	poster="<?php echo esc_attr($videoPosterUrl); ?>"
 	<?php if ($videoPosterUrl) { ?>
 		poster="<?php echo esc_attr($videoPosterUrl); ?>"
 	<?php } ?>

diff --git a/blocks/init/src/Blocks/custom/site-footer/manifest.json b/blocks/init/src/Blocks/custom/site-footer/manifest.json
@@ -25,7 +25,7 @@
 			"type": "string"
 		},
 		"siteFooterLogoId": {
-			"type": "string"
+			"type": "number"
 		},
 		"siteFooterCopyright": {
 			"type": "string"

diff --git a/blocks/init/src/Blocks/custom/site-navigation/manifest.json b/blocks/init/src/Blocks/custom/site-navigation/manifest.json
@@ -26,7 +26,7 @@
 			"type": "string"
 		},
 		"siteNavigationLogoId": {
-			"type": "string"
+			"type": "number"
 		},
 		"wrapperUse": {
 			"type": "boolean",