Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifest combinations #48

Closed
wants to merge 1 commit into from
Closed

Update manifest combinations #48

wants to merge 1 commit into from

Conversation

kancijan
Copy link
Contributor

Description

Fix for manifest combinations when the value is a boolean in string. E.g., "true" or "false."
Previously, this would fail due to checkAttr() returning a boolean false that would fail on the first !value check.

Fix for manifest combinations when the value is a boolean in string. E.g., "true" or "false."
@iruzevic
Copy link
Member

Why would you have boolean in string?

@kancijan
Copy link
Contributor Author

Why would you have boolean in string?
@iruzevic
image

@iruzevic
Copy link
Member

I don't understand. Why this can't be bool like it is defined in the attributes?

@kancijan
Copy link
Contributor Author

@iruzevic because we have toggles and when checking false we have false positive in first check. This logic is already implemented in PHP.

I'm now testing another approach suggested by Goc.

@kancijan
Copy link
Contributor Author

A new conclusion is that we have a misleading schema setup.
image

Booleans were supported, but the warning messages made me believe that strings must be used.
image

I'll revert the logic in the libs and update the schema. Also, update manifests in existing blocks and components that use combinations.

@kancijan kancijan closed this Sep 24, 2024
@kancijan kancijan deleted the kancijan-patch-1 branch September 24, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants