Add w-full to Image if aspect-ratio is set to apply the effect #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goranalkovic-infinum
requested changes
Oct 15, 2024
| "five-four": "aspect-5/4", | ||
| "sixteen-nine": "aspect-video", | ||
| "twentyone-nine": "aspect-21/9" | ||
| "square": "aspect-square w-full", |
There was a problem hiding this comment.
This should be set in the block, not the component
Components should be neutral sizing-wise, if possible
goranalkovic-infinum
requested changes
Oct 16, 2024
piqusy
requested review from
goranalkovic-infinum
and removed request for
goranalkovic-infinum
goranalkovic-infinum
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add w-full to Image if aspect-ratio is set to apply the effect
Screenshots / Videos
Here is an example for "square" aspect-ratio but this applies to all variants:
Screen.Recording.2024-10-15.at.15.50.06.mov