[Task #876] Add license scanning setup to the template #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anamarijabalaban
force-pushed
the
feature/876-add-license-scanning
branch
from
2e21857 to
beff1fc
Compare
vr4b4c
requested changes
Jun 20, 2025
Comment on lines
+12
to
+19
| LicenseFinder: | ||
| enabled: true | ||
| on_warn: fail | ||
| command: ['bundle', 'exec', 'license_finder'] | ||
| requires_files: true | ||
| include: | ||
| - 'Gemfile*' | ||
| - 'package.json' |
There was a problem hiding this comment.
I think this needs to be indented one more level to the left to be correctly nested under PreCommit section.
vr4b4c
requested changes
Jun 20, 2025
|
|
||
| append_to_file 'Gemfile', after: /gem 'rubocop-infinum'.*\n/ do | ||
| <<~HEREDOC | ||
| gem 'license_finder', require: false |
There was a problem hiding this comment.
Indentation problem here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a license scanning to the Rails template.
Related issue: None
Changes
Type
Additional information
Description
Add license_finder recipe and run license_finder commands in run_generators.rb.
Checklist
Additional notes