feat: show actual record size when throw maximum request size error (#…

…4251)

Cargo.toml

@@ -166,7 +166,7 @@ k8-diff = { version = "0.1.2" }
 trybuild = { branch = "check_option", git = "https://github.com/infinyon/trybuild" }
 
 # Internal fluvio dependencies
-fluvio = { version = "0.24.0", path = "crates/fluvio" }
+fluvio = { version = "0.25.0", path = "crates/fluvio" }
 fluvio-auth = { path = "crates/fluvio-auth" }
 fluvio-channel = { path = "crates/fluvio-channel" }
 fluvio-cli-common = { path = "crates/fluvio-cli-common"}

crates/fluvio/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "fluvio"
-version = "0.24.0"
+version = "0.25.0"
 edition = "2021"
 license = "Apache-2.0"
 authors = ["Fluvio Contributors <[email protected]>"]

crates/fluvio/src/producer/error.rs

@@ -9,8 +9,8 @@ use crate::producer::PartitionId;
 #[derive(thiserror::Error, Debug, Clone)]
 #[non_exhaustive]
 pub enum ProducerError {
-    #[error("the given record is larger than the max_request_size ({0} bytes)")]
-    RecordTooLarge(usize),
+    #[error("record size ({0} bytes), exceeded maximum request size ({0} bytes)")]
+    RecordTooLarge(usize, usize),
     #[error("failed to send record metadata: {0}")]
     SendRecordMetadata(#[from] async_channel::SendError<RecordMetadata>),
     #[error("failed to get record metadata")]

crates/fluvio/src/producer/memory_batch.rs

@@ -59,7 +59,10 @@ impl MemoryBatch {
         // Error if the record is too large
         if actual_batch_size > self.write_limit {
             self.is_full = true;
-            return Err(ProducerError::RecordTooLarge(actual_batch_size));
+            return Err(ProducerError::RecordTooLarge(
+                record_size,
+                actual_batch_size,
+            ));
         }
 
         // is full, but is first record, add to the batch and then we will send it directly

rfc/produce-message-size.md

@@ -57,7 +57,7 @@ fluvio produce large-data-topic --max-request-size 16384 --file large-data-file.
 Will be displayed the following error:
 
 ```bash
-the given record is larger than the max_request_size (16384 bytes).
+record size (xyz bytes), exceeded maximum request size (1048576 bytes)
 ```
 
 ### Compression

tests/cli/fluvio_smoke_tests/produce-error.bats

@@ -49,7 +49,7 @@ teardown_file() {
         skip "don't check output on stable version"
     fi
 
-    assert_output --partial "the given record is larger than the max_request_size"
+    assert_output --partial "exceeded maximum request size"
 }
 
 # This should fail due to wrong compression algorithm