Merge pull request #225 from eduardoj/feature/add_cached_to_active_re…

…cord Add `cached` key for active_record payloads
influxdata · May 28, 2024 · 281ee2b · 281ee2b
2 parents 52f6d70 + 4fae494
commit 281ee2b
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/lib/influxdb/rails/middleware/sql_subscriber.rb b/lib/influxdb/rails/middleware/sql_subscriber.rb
@@ -21,6 +21,7 @@ def tags
             class_name: query.class_name,
             name:       query.name,
             location:   :raw,
+            cached:     query.try(:cached) == "true",
           }
         end
 

diff --git a/spec/requests/active_record_sql_metrics_spec.rb b/spec/requests/active_record_sql_metrics_spec.rb
@@ -21,7 +21,8 @@
         hook:       "sql",
         name:       "Metric Create",
         class_name: "Metric",
-        operation:  "INSERT"
+        operation:  "INSERT",
+        cached:     false
       ),
       fields: a_hash_including(
         additional_field: :value,
@@ -40,7 +41,8 @@
     expect_metric(
       tags: a_hash_including(
         location: "MetricsController#index",
-        hook:     "sql"
+        hook:     "sql",
+        cached:   false
       ),
       time: Time.at(1_514_797_200)
     )
@@ -53,7 +55,8 @@
 
     expect_no_metric(
       tags: a_hash_including(
-        hook:     "sql"
+        hook:   "sql",
+        cached: false
       )
     )
   end

diff --git a/spec/requests/context_spec.rb b/spec/requests/context_spec.rb
@@ -7,7 +7,8 @@
     expect_metric(
       tags: a_hash_including(
         location: "MetricsController#index",
-        hook:     "sql"
+        hook:     "sql",
+        cached:   false
       )
     )