Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far we only created one instance of the middleware and then operated on this instance. This made the code quite ugly because we always needed to pass around the method parameters from method to method. This PR creates now a new instance for each request.
The main part what I changed is basically from
to
which resulted that we basically dropped all method parameters from all functions. In my opinion this makes the code a lot nicer to work with because we can easily extract helper methods and memoize values. This refactoring is a preparation for #117 which made it quite hard to squeeze more code without the ability to have helper methods.
Downside of this approach is of course that we create a few more instances per request but I think this is worth it.