Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set file pattern only if it is passed from the from command line #229

Merged

Conversation

eduardoj
Copy link
Contributor

No description provided.

@eduardoj eduardoj force-pushed the refactoring/rake_spec_parameters branch from 67205bd to 47abe41 Compare May 28, 2024 11:00
@hennevogel
Copy link
Collaborator

Because?

@eduardoj
Copy link
Contributor Author

Because?

I don't see we need to deviate from the default, regarding the pattern of files to be tested. The default works fine, too. See:

https://github.com/rspec/rspec-core/blob/5699fcdc4723087ff6139af55bd155ad9ad61a7b/lib/rspec/core/rake_task.rb#L28

@hennevogel hennevogel merged commit cdc4b26 into influxdata:master May 31, 2024
10 of 13 checks passed
@eduardoj eduardoj deleted the refactoring/rake_spec_parameters branch May 31, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants